Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leaky goroutine on metrics-collector #1733

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix leaky goroutine on metrics-collector #1733

wants to merge 2 commits into from
+111 −9

Conversation

saswatamcode
Copy link
Member

Without this, it starts a new routine when workers are > 1 which sends requests to federate with 0 limit byte

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saswatamcode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saswatamcode
Check simulated series file
8c1ab58 
Signed-off-by: Saswata Mukherjee <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
33.3% Coverage on New Code (required ≥ 70%)
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 18, 2024 •
edited
Loading

@saswatamcode: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-unit 8c1ab58 link true /test test-unit
ci/prow/sonarcloud 8c1ab58 link false /test sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipgough philipgough Awaiting requested review from philipgough

@coleenquadros coleenquadros Awaiting requested review from coleenquadros

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
approved dco-signoff: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@saswatamcode